efriedma added a comment. Sorry about the delayed response, I was traveling.
================ Comment at: clang/docs/LanguageExtensions.rst:2252 + + * ``__builtin_memcpy_inline`` + ---------------- gchatelet wrote: > efriedma wrote: > > This is in the wrong section of the documentation. We could > > constant-evaluate __builtin_memcpy_inline, I guess, but that isn't the > > primary purpose, and your patch doesn't implement constant evaluation > > anyway. > > > > Might make sense to add a new section, if no existing section makes sense. > I added a new `memory builtins` section. Let me know what you think. Makes sense. ================ Comment at: clang/docs/LanguageExtensions.rst:2229 +* ``memcpy`` * ``memchr`` ---------------- Not sure putting "memcpy" in this list makes sense. We did add support for constant-evaluating memcpy, but it was separately from the others, so the description of the feature detection is wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
