jdoerfert added a comment. (I'll try to actually review this later but I left a comment below)
================ Comment at: clang/test/Driver/clang-offload-bundler-missing-size-section.cpp:1-44 +// REQUIRES: x86-registered-target +// RUN: %clangxx -c %s -o %t_fat.o +// RUN: %clangxx %t_fat.o -o %t.exe +// RUN: clang-offload-bundler -type=o -targets=host-x86_64-unknown-linux-gnu,openmp-x86_64-pc-linux-gnu -outputs=%t_host.o,%t_device.o -inputs=%t_fat.o -unbundle +// RUN: %t.exe %t_device.o | FileCheck %s +// CHECK:11 + ---------------- ABataev wrote: > Very strange test. It should not contain standard includes. Also, it should > not be an executable test, you have to check for the driver output or > something similar We have executable tests in the OpenMP target offloading part, if it cannot live with clang it can live there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74262/new/ https://reviews.llvm.org/D74262 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
