efriedma added a comment. In D71600#1867320 <https://reviews.llvm.org/D71600#1867320>, @adalava wrote:
> > For compiler-rt, are you really disabling > > COMPILER_RT_EXCLUDE_ATOMIC_BUILTIN? Are you sure you understand the > > implications of that? > > I didn't understood "disable COMPILER_RT_EXCLUDE_ATOMIC_BUILTIN", it's not > intentional. > If it's the change around atomic.c:131, what I expect is make IS_LOCK_FREE_8 > return false. I don't want it to make to __c11_atomic_is_lock_free(8) as it > generates code that should be linked with a libatomic at run time. On master, atomic.c is not built by default. It's only built if you explicitly request it with something like the CMake flag -DCOMPILER_RT_EXCLUDE_ATOMIC_BUILTIN=Off . If you're not doing that, any change to atomic.c has no effect. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71600/new/ https://reviews.llvm.org/D71600 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
