thakis added inline comments.
================
Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1239
+ llvm::Regex("(/\\*[ \\t]*fall(s | |-)?thr(ough|u)\\.?[
\\t]*\\*/)"
+ "|(//[ \\t]*fall(s | |-)?thr(ough|u)\\.?[ \\t]*)",
+ llvm::Regex::IgnoreCase);
----------------
Also, this adds a regex match for every comment line, yes? Isn't this terrible
for build performance? Did you do any benchmarking of this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73852/new/
https://reviews.llvm.org/D73852
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
