Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land.
LGTM, I like everything here, you worded the notes very nicely and the test cases seems to cover everything I could find! Please wait for @NoQ's approval, since he's the ranking member of among the `NoteTag` users. In D73720#1871975 <https://reviews.llvm.org/D73720#1871975>, @baloghadamsoftware wrote: > In D73720#1871955 <https://reviews.llvm.org/D73720#1871955>, @Szelethus wrote: > > > Do we have a test where 2 containers are present but only one of them > > should be marked as interesting? > > > Yes, of course we have, that was the starting point of the discussion. > However, I try to make the tests orthogonal, so this test is in > `container-modeling.cpp` where we do not dereference it, but print its begin > or end. Yea, right, silly me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73720/new/ https://reviews.llvm.org/D73720 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
