dmajor added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:339 // Add the deployment target. - MachOTC.addMinVersionArgs(Args, CmdArgs); + if (!Version[0] || Version[0] >= 520) + MachOTC.addPlatformVersionArgs(Args, CmdArgs); ---------------- arphaman wrote: > steven_wu wrote: > > Why version '0' should go through the new path? > Version `0` indicates that `-mlinker-version=` wasn't specified. We want to > use the new flag by default. Hi. Just for anyone who isn't on the bugzilla thread: in https://bugs.llvm.org/show_bug.cgi?id=44813 I'd like to reconsider this decision about using the flag by default. It is a breaking change and is inconsistent with the other treatments of `Version` in this function. What do you all think? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
