hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:345
+
+ SPAN_ATTACH(Tracer, FileAndOccurrences.first(),
+ static_cast<int64_t>(Ranges.size()));
----------------
kbobyrev wrote:
> A tracer message here would be helpful!
the message now would be the <filename, num_of_ranges> and under the
`FindOccurrencesOutsideFile` span, I think it is clear enough?
================
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:627
if (Indexed.size() > Lexed.size()) {
vlog("The number of lexed occurrences is less than indexed occurrences");
----------------
kbobyrev wrote:
> Maybe add the tracer here, too?
ah, good point. I missed this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74395/new/
https://reviews.llvm.org/D74395
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
