aprantl added a comment.
The upgrade test look good, I found a missing test in the unit tests though.
================
Comment at: llvm/unittests/IR/MetadataTest.cpp:2089
+ EXPECT_NE(N, DITemplateTypeParameter::get(Context, Name,
+ getBasicType("other"), false));
----------------
I think you also need to add a new line here that tests that two
DITemplateTypeParameter that only differ in the isDefault parameter are not
equal. This tests the hashing/comparison mechanism.
================
Comment at: llvm/unittests/IR/MetadataTest.cpp:2120
+ EXPECT_NE(N, DITemplateValueParameter::get(Context, Tag, Name, Type, false,
getConstantAsMetadata()));
----------------
and here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73462/new/
https://reviews.llvm.org/D73462
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
