jdoerfert marked 11 inline comments as done.
jdoerfert added inline comments.
================
Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:367
} else {
- llvm_unreachable("Unknown SimpleArgument type!");
+ OS << " if (SA->get" << getUpperName() << "())\n ";
+ OS << " OS << \" \" << *SA->get" << getUpperName() << "();\n";
----------------
aaron.ballman wrote:
> Can we leave the unreachable in there and add actual checking for this case?
> The unreachable is intended to remind people "do this work when you're
> mucking about in here" and silently doing something that may or may not be
> wrong makes this harder to spot.
Overlooked this one, sorry. Will fix it and make it unreachable again.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71830/new/
https://reviews.llvm.org/D71830
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
