kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:106
+  case SK::ConversionFunction:
+    return CompletionItemKind::Operator;
   case SK::Variable:
----------------
I believe `function` still captures the intend better here, as you can only see 
the completion if you are literally completing for `Foo.operator X()` (btw, I 
am not even sure if we show completions for those, we might have another bug 
around this one).

So I would keep it the same, but up to you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74609/new/

https://reviews.llvm.org/D74609



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to