[AMD Official Use Only - Internal Distribution Only] Reverted.
I will make sure it does not regress mlir before commit again. Thanks. Sam -----Original Message----- From: Eric Christopher via Phabricator <revi...@reviews.llvm.org> Sent: Tuesday, February 18, 2020 11:21 AM To: Liu, Yaxun (Sam) <yaxun....@amd.com>; t...@google.com; rjmcc...@gmail.com; rich...@metafoo.co.uk; jdoerf...@anl.gov; a.bat...@hotmail.com Cc: jpien...@google.com; mask...@google.com; michael.hl...@gmail.com; mariya.podchishcha...@intel.com; alexey.ba...@intel.com; zhang.guans...@gmail.com; her...@google.com; r...@google.com; cfe-commits@lists.llvm.org; mlek...@skidmore.edu; blitzrak...@gmail.com; shen...@google.com Subject: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese [CAUTION: External Email] echristo added a comment. In D70172#1879481 <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD70172%231879481&data=02%7C01%7Cyaxun.liu%40amd.com%7Ce901b932c7c140a8a22c08d7b4a7b390%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637176504711389865&sdata=8ifPEoeddzVyx3dpbTAvPeGKoa3oaTb6n18K6S5cVtY%3D&reserved=0>, @jpienaar wrote: > This seems to result in triggering clang/lib/CodeGen/CGExpr.cpp:2626 when > compiling mlir/lib/Transforms/AffineDataCopyGeneration.cpp with clang build > with assertions on (clean build at e8e078c > <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FrGe8e078c8bf7987b95298062a644bac9eed26f988&data=02%7C01%7Cyaxun.liu%40amd.com%7Ce901b932c7c140a8a22c08d7b4a7b390%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637176504711389865&sdata=sM7yVx1tX%2BfMXRAvKKNMfXefVOQrg9LPxOXx1ByKAZs%3D&reserved=0> > just before this change, broken at this, assert triggering at build fix > commit). > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbuildkite.com%2Fmlir%2Fmlir-core%2Fbuilds%2F2792%23a54fb239-718b-4f0b-a309-f83e46ceb252&data=02%7C01%7Cyaxun.liu%40amd.com%7Ce901b932c7c140a8a22c08d7b4a7b390%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637176504711389865&sdata=8OqEGO2vIUaVIEsaRfhzmTgJRGnMFR2ZpXH2LSkr9Ds%3D&reserved=0 Seems reasonable to revert if there's a testcase that they can get from rebuilding llvm with mlir enabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD70172%2Fnew%2F&data=02%7C01%7Cyaxun.liu%40amd.com%7Ce901b932c7c140a8a22c08d7b4a7b390%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637176504711389865&sdata=64lMij5bibrJnOLdYufLxO5u3GNpJe%2BzoSOdYef7zyw%3D&reserved=0 https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD70172&data=02%7C01%7Cyaxun.liu%40amd.com%7Ce901b932c7c140a8a22c08d7b4a7b390%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637176504711389865&sdata=hfZYdMzByxpdoxtqLEP%2FAHWNKBHWkcXRbqXtrSqCfE4%3D&reserved=0 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
