silvas added a subscriber: silvas. silvas added a comment. Some nits but this looks fine to me. I've been wanting this for a while now.
================ Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:347 @@ +346,3 @@ + + if (UseLinker[0] == '/') { + // If we're passed -fuse-ld= with what looks like an absolute path, ---------------- Use llvm::sys::path::is_absolute so that this works on windows. ================ Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:352 @@ +351,3 @@ + return UseLinker; + } else { + // If we're passed -fuse-ld= with no argument, or with the argument ld, ---------------- No need for else after return. Repository: rL LLVM http://reviews.llvm.org/D17952 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits