john.brawn added a comment. Looking at http://reviews.llvm.org/D15729 I //think// there's no conflict between what this patch is doing and what that patch is doing. If a plugin returns AddBeforeMainAction or AddAfterMainAction then when ASTUnit in libclang loads that plugin it should get automatically added in FrontendAction::CreateWrappedASTConsumer, which is what I would expect should happen. There's a question of whether lines 199-210 of ExecuteCompilerInvocation.cpp should get moved into the CompilerInstance::loadPlugins function that http://reviews.llvm.org/D15729 adds and I think the answer there is no - looking at ASTUnit it doesn't seem to use getFrontendOpts().ProgramAction at all, so there's no point setting it based on a plugin.
Repository: rL LLVM http://reviews.llvm.org/D17959 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
