sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7495
+ // DUPQ can be used when idx is in range.
+ auto CIdx = dyn_cast<ConstantSDNode>(Idx128);
+ if (CIdx && (CIdx->getZExtValue() <= 3)) {
----------------
nit: `auto *CIdx`
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7496
+ auto CIdx = dyn_cast<ConstantSDNode>(Idx128);
+ if (CIdx && (CIdx->getZExtValue() <= 3)) {
+ auto CI = DAG.getTargetConstant(CIdx->getZExtValue(), DL, MVT::i64);
----------------
nit: can you replace `auto` in these cases with SDValue? (which I think this
is?)
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7506
+ // index * 2))
+ auto Zero = DAG.getConstant(0, DL, MVT::i64);
+ auto One = DAG.getConstant(1, DL, MVT::i64);
----------------
nit: please move `Zero` down to its use below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74734/new/
https://reviews.llvm.org/D74734
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
