fickert added a comment.

I understand the caution around changing the unit tests. The tests I modified 
assumed that alignment would be made with mixed tabs and spaces, which is 
arguably not the expected behavior with `UT_ForContinuationAndIndentation` (see 
https://bugs.llvm.org/show_bug.cgi?id=38381).  I removed a test case that was a 
duplicate (the one in line 10293 is identical to the one in line 10182, and 
there are no changes to the formatting configuration in between). I added two 
test cases to ensure that the behavior is consistent for alignment in 
multi-line comments, e.g. the formatted code should be

  {
  \t/* aaaa
  \t   bbbb
  }

instead of

  {
  \t/* aaaa
  \t\t bbbb
  }

when using `UT_ForContinuationAndIndentation` and a tab width of 2.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75034/new/

https://reviews.llvm.org/D75034



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to