njames93 marked an inline comment as done.
njames93 added inline comments.

================
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4772
+///
+/// FIXME: Tweak to improve docs generated
+extern const internal::VariadicFunction<internal::HasOpNameMatcher, StringRef,
----------------
gribozavr2 wrote:
> Any specific things you would like to improve? The fixme is rather vague.
This is what comes up in the ASTMatchersReference docs. 
```
Matcher<internal::HasOpNameMatcher>     hasAnyOperatorName      StringRef, ..., 
StringRef```
I would like it to have 
```
Matcher<BinaryOperator>  hasAnyOperatorName     StringRef, ..., StringRef
...
Matcher<UnaryOperator>  hasAnyOperatorName      StringRef, ..., StringRef```
However how VariadicFunction is matched in the dumper won't support that yet. 
And If you want to support it properly regex wouldn't work, instead you'd need 
a parser


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75040/new/

https://reviews.llvm.org/D75040



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to