dmajor added a comment. @steven_wu, ping, could you clarify about the tests please?
>> You should definitely add test for this change. The fact that you change all >> `-mlinker-version=400` to `-mlinker-version=0` but not change any CHECK >> lines means the change is definitely not tested :) > > Can you elaborate on what you would like to see tested? I thought I _was_ > updating the tests to match the code. The `-mlinker-version=0` lines check > that we now use the old behavior by default, and the existing > `-mlinker-version=520` lines in e.g. `darwin-ld-platform-version-macos.c` > test that we still use the new behavior when requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74784/new/ https://reviews.llvm.org/D74784 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
