ABataev added a comment.

Also, would be good to add more tests for the situations that should not be 
handled, like just `(a+b)`, explicit casts, etc.



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9966
+def err_omp_non_lvalue_in_map_or_motion_clauses: Error<
+  "expected addressable lvalue in '#pragma omp target update' and '#pragma omp 
target map'"
+  >;
----------------
I still would change this message to something like `expected addressable 
lvalue in '%0' clause`, where `%0` must be one of `map|to|from` to be more 
specific and correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75077/new/

https://reviews.llvm.org/D75077



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to