erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land.
In D74417#1876927 <https://reviews.llvm.org/D74417#1876927>, @dgoldman wrote: > Okay, I've added this, it seems to fix the test but I'm not sure if it's > fully correct since the place where it was modified is under the `VarDecl` > comment instead of `ParmVarDecl`. It looks like it's in ParmVarDecl to me, its just in the VarDecl region of the complete record. ParmVarDecl inherits from VarDecl, so when parameters are pseudo-strong, that information is stored in the bit in the VarDecl. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74417/new/ https://reviews.llvm.org/D74417 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
