yaxunl added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1919
void CodeGenModule::addUsedGlobal(llvm::GlobalValue *GV) {
LLVMUsed.emplace_back(GV);
----------------
hliao wrote:
> This check should be removed completely instead it should be revised for the
> exceptions.
How about add back this assertion but make an exception for global variables
with hip_pinned_shadow attribute.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75402/new/
https://reviews.llvm.org/D75402
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
