akhuang marked an inline comment as done. akhuang added inline comments.
================ Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:989 + llvm::DINode::DIFlags Flags = llvm::DINode::FlagFwdDecl; + if (const CXXRecordDecl *CXXRD = dyn_cast<CXXRecordDecl>(RD)) + if (!CXXRD->hasDefinition() || ---------------- rnk wrote: > I think this code block needs a comment about the behavior we are trying to > implement. It could be made CodeView-specific, but I don't see a strong > reason not to set these flags when emitting DWARF. Yep, will add a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
