[PATCH] D75971: Should not need the second predicate.If `II->hasMacroDefinition()` is true, then the whole expr is always true.

[Vy Nguyen via Phabricator via cfe-commits]

oontvoo created this revision.
oontvoo added a reviewer: jyknight.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

remove redundant pred


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75971

Files:
  clang/include/clang/Lex/Preprocessor.h


Index: clang/include/clang/Lex/Preprocessor.h
===================================================================
--- clang/include/clang/Lex/Preprocessor.h
+++ clang/include/clang/Lex/Preprocessor.h
@@ -1042,8 +1042,7 @@
     return isMacroDefined(&Identifiers.get(Id));
   }
   bool isMacroDefined(const IdentifierInfo *II) {
-    return II->hasMacroDefinition() &&
-           (!getLangOpts().Modules || (bool)getMacroDefinition(II));
+    return II->hasMacroDefinition();
   }
 
   /// Determine whether II is defined as a macro within the module M,



Index: clang/include/clang/Lex/Preprocessor.h
===================================================================
--- clang/include/clang/Lex/Preprocessor.h
+++ clang/include/clang/Lex/Preprocessor.h
@@ -1042,8 +1042,7 @@
     return isMacroDefined(&Identifiers.get(Id));
   }
   bool isMacroDefined(const IdentifierInfo *II) {
-    return II->hasMacroDefinition() &&
-           (!getLangOpts().Modules || (bool)getMacroDefinition(II));
+    return II->hasMacroDefinition();
   }
 
   /// Determine whether II is defined as a macro within the module M,

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits