It is a matter of taste, but for me it looks strange to develop complex and error-prone system to save 7 bits at expense of readability and maintainability. My observations show that clang AST consumes much less memory than llvm objects.
FPOption could be shared between user using something like shared_ptr, but it means expenses of 64 bit for a pointer. Don't know if it makes sense... Thanks, --Serge On Wed, Mar 11, 2020 at 6:30 PM Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall added a comment. > > This patch increased the used size of BinaryOperator by 5 bits. > Those bits were all padding, but now BinaryOperatorBitfields is completely > full at 32 bits and we can't add any new bits to Stmt without increasing > BinaryOperator by 8 bytes. (See D75443 <https://reviews.llvm.org/D75443> > and D54526 <https://reviews.llvm.org/D54526> for the optimization this > would revert). > > To squeeze in the new bit I'm planning to suggest squeezing getInt() to 7 > bits (it encodes 3x2x5x3 = 90 states, so this is possible) but I'm not > really familiar with this domain - if many of the 90 states are not > possible it'd probably be useful to have some more bits back :-) > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D65994/new/ > > https://reviews.llvm.org/D65994 > > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
