MaskRay added a comment. The GCC side commits can be found on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92055 So it seems that we will have both `-mlong-double-{64,80,128}` (80 is used by x86 fp80) and `-mlong-double={32,64}`... (I actually prefer `=` to `-`)
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4594 + if (Arg *A = Args.getLastArg(options::OPT_mdouble_EQ)) { + if (TC.getArch() == llvm::Triple::avr) ---------------- Nit: move this before the `-mlong-double-` processing. ================ Comment at: clang/test/CodeGen/mdouble.c:1 +// RUN: %clang_cc1 %s -emit-llvm -o - -triple=avr-unknown-unknown -mdouble=64 | \ +// RUN: FileCheck --check-prefix=AVR-FP64 %s ---------------- Maybe name this file `avr-mdouble.c` ================ Comment at: clang/test/Driver/mdouble.c:1 +// RUN: %clang -target avr-unknown-unknown -c -### %s -mdouble=64 2>&1 | FileCheck %s + ---------------- `-unknown-unknown` can be deleted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76181/new/ https://reviews.llvm.org/D76181 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits