baloghadamsoftware marked 2 inline comments as done.
baloghadamsoftware added inline comments.
Herald added a subscriber: DenisDvlp.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542
+ BR.markInteresting(It1);
+ if (const auto &LCV1 = It1.getAs<nonloc::LazyCompoundVal>()) {
+ BR.markInteresting(LCV1->getRegion());
+ }
----------------
NoQ wrote:
> I'm opposed to this code for the same reason that i'm opposed to it in the
> debug checker. Parent region is an undocumented implementation detail of
> `RegionStore`. It is supposed to be immaterial to the user. You should not
> rely on its exact value.
>
> @baloghadamsoftware Can we eliminate all such code from iterator checkers and
> instead identify all iterators by regions in which they're stored? Does my
> improved C++ support help with this anyhow whenever it kicks in?
How to find the region where it is stored? I am open to find better solutions,
but it was the only one I could find so far. If we ignore `LazyCompoundVal`
then everything falls apart, we can remove all the iterator-related checkers.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75677/new/
https://reviews.llvm.org/D75677
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
