lebedev.ri added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1129
+ // should get unique names. Use the hash of module name to get a unique
+ // identifier and this is a best effort.
+ if (getCodeGenOpts().UniqueInternalFuncNames &&
----------------
maybe
`identifier as this is a best-effort solution`
================
Comment at: clang/test/CodeGen/unique-internal-funcnames.c:16
+// UNIQUE-NOT: foo:
+// UNIQUE: foo.{{[0-9a-f]+}}:
----------------
What does `getModule().getSourceFileName()` contain?
The full path to the source file, or just the source file basename?
If latter, maybe check the full name?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73307/new/
https://reviews.llvm.org/D73307
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
