alexfh added a comment. In D75184#1914788 <https://reviews.llvm.org/D75184#1914788>, @njames93 wrote:
> In D75184#1914705 <https://reviews.llvm.org/D75184#1914705>, @DmitryPolukhin > wrote: > > > You are absolutely right about current behaviour. Thank you for catching > > this odd behaviour. I'm not 100% confident what is the right behaviour but > > my guess is that overriding local option from parent config with global > > from child folder is better so I implemented it and added corresponding > > test. > > > It's a tricky one that, but I thing overriding the local option with the > global in the sub directory is the correct way to go about this as well. There's one more thing to consider: just by looking at the name of a local option we don't know whether it will be read using `get()` or `getLocalOrGlobal()`. By removing local options we may introduce an even more surprising behavior than without this special treatment. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
