dblaikie added a comment.

@leonardchan sorry for the inconvenience, but Phabricator has a bug/missing 
feature where it doesn't send mail for bug updates that contain no 
user-authored text, so approving a patch without writing anything in the text 
box doesn't send an email to the mailing lrist (the mailing list is still 
considered the canonical source of truth for reviews, etc) and thus makes it 
looks like patches are being committed without review. When approving a patch 
through phab, please write something (eg: "Thanks!", "Looks good!", etc) in the 
text box to workaround this bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76189/new/

https://reviews.llvm.org/D76189



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to