hokein added a comment.
In D76696#1939513 <https://reviews.llvm.org/D76696#1939513>, @sammccall wrote:
> Do you also want to update LangOpts.td to make the default for the langopt
> equal to CPlusPlus?
> (I saw other opts doing that, not sure exactly what it affects, may be
> voodoo cargo cult stuff)
ah, I missed that.
================
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1198
#define ID(X) X
- ID(foo $p^( foo(10), ^ ))
+ ID(foo $p^( 10, ^ ))
})cpp"};
----------------
sammccall wrote:
> Why did the original test start failing? Is this a regression?
>
> (This certainly seems OK to regress and fix later, but there may be other
> consequences?)
yes, but I didn't dig into it, it is likely a regression, added a FIXME
(looking at other cases in this test, they just use `10` as the parameter).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76696/new/
https://reviews.llvm.org/D76696
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
