Author: Eli Friedman Date: 2020-03-25T10:58:03-07:00 New Revision: c46a0c07a634d85d3fed2ef94747ea19fb4d2d69
URL: https://github.com/llvm/llvm-project/commit/c46a0c07a634d85d3fed2ef94747ea19fb4d2d69 DIFF: https://github.com/llvm/llvm-project/commit/c46a0c07a634d85d3fed2ef94747ea19fb4d2d69.diff LOG: [clang codegen] Address review comment on comment in constWithPadding. Added: Modified: clang/lib/CodeGen/CGDecl.cpp Removed: ################################################################################ diff --git a/clang/lib/CodeGen/CGDecl.cpp b/clang/lib/CodeGen/CGDecl.cpp index a6417f05a7a6..a9dbdb2e8713 100644 --- a/clang/lib/CodeGen/CGDecl.cpp +++ b/clang/lib/CodeGen/CGDecl.cpp @@ -1075,7 +1075,9 @@ static llvm::Constant *constWithPadding(CodeGenModule &CGM, IsPattern isPattern, auto *NewArrayTy = llvm::ArrayType::get(NewElemTy, Size); return llvm::ConstantArray::get(NewArrayTy, Values); } - // FIXME: Do we need to handle tail padding in vectors? + // FIXME: Add handling for tail padding in vectors. Vectors don't + // have padding between or inside elements, but the total amount of + // data can be less than the allocated size. return constant; } _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
