craig.topper added a comment.

In D76525#1942825 <>, @zoecarver wrote:

> @craig.topper I'm not sure what should happen. It should probably just use 
> that CPU (although that's not a great solution). Is there a way to detect if 
> an attribute was used to change the target in which case we could error? What 
> do you think should happen?

I'm not sure what should happen as I'm not familiar with the library feature 
being implemented. As implemented here, the target attribute will be ignored 
and it will just follow the command line. Why do you say that following the 
attribute is not a great solution?

Comment at: clang/test/SemaCXX/builtin-cache-line-size.cpp:1
+// RUN: %clang -mcpu=i368 %s
+// RUN: ./a.out
This say i368 which is not a valid cpu. Did you mean i386? Also x86 uses use 
-march not -mcpu. I don't think -mcpu does anything.

  rG LLVM Github Monorepo


cfe-commits mailing list

Reply via email to