Thanks for catching that.
On Thu, Mar 26, 2020 at 11:14 PM David Blaikie <dblai...@gmail.com> wrote: > > Usually this sort of thing is addressed with llvm_unreachable, rather than a > return statement that's not expected to be reached by any valid execution of > LLVM (it'd require a carefully hand-crafted CPU kind to reach that return > (since all the actual enumerators result in returns earlier, in the switch > statement above), which probably isn't an intended code path?) > > I've made that change in 819e540208d5d62e7841d0dbdef3580eecc2c2b6 > > On Wed, Mar 25, 2020 at 9:59 PM Michael Liao via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> >> Author: Michael Liao >> Date: 2020-03-26T00:53:24-04:00 >> New Revision: d264f02c6f502960e2bcdd332f250efc702d09f2 >> >> URL: >> https://github.com/llvm/llvm-project/commit/d264f02c6f502960e2bcdd332f250efc702d09f2 >> DIFF: >> https://github.com/llvm/llvm-project/commit/d264f02c6f502960e2bcdd332f250efc702d09f2.diff >> >> LOG: Fix `-Wreturn-type` warning. NFC. >> >> Added: >> >> >> Modified: >> clang/lib/Basic/Targets/X86.cpp >> >> Removed: >> >> >> >> ################################################################################ >> diff --git a/clang/lib/Basic/Targets/X86.cpp >> b/clang/lib/Basic/Targets/X86.cpp >> index f35b520de657..8a7d0f17760e 100644 >> --- a/clang/lib/Basic/Targets/X86.cpp >> +++ b/clang/lib/Basic/Targets/X86.cpp >> @@ -1842,6 +1842,7 @@ Optional<unsigned> >> X86TargetInfo::getCPUCacheLineSize() const { >> case CK_Generic: >> return None; >> } >> + return None; >> } >> >> bool X86TargetInfo::validateOutputSize(const llvm::StringMap<bool> >> &FeatureMap, >> >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
