yaxunl added a comment. In D76987#1950366 <https://reviews.llvm.org/D76987#1950366>, @gregrodgers wrote:
> This was discussed on llvm-dev three years ago. Here is the thread. > > http://lists.llvm.org/pipermail/llvm-dev/2017-February/109930.html > > The last name discussed was "-- offload-arch". I don't believe we need a > list option anymore. So ignore the very old request for --offload-archs. > > I am ok with the patch the way it is. In the future, we should consider > renaming the CudaArch class to OffloadArch class . Also the GpuArchList is > currently only initialized in CudaActionBuilder. Eventually this is will > have to be done for HIPActionBuilder and OpenMPActionBuilder. Could you > consider creating a function to InitializeGpuArchList ? GpuArchList is initialized by member function initialize() of CudaActionBuilderBase, which is inherited by CudaActionBuilder and HIPActionBuilder, therefore GpuArchList is initialized in both CudaActionBuilder and HIPActionBuilder. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76987/new/ https://reviews.llvm.org/D76987 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
