Charusso accepted this revision. Charusso marked an inline comment as done. Charusso added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:512 + return E->IgnoreImpCasts(); } ---------------- thakis wrote: > NoQ wrote: > > Charusso wrote: > > > I think it would make sense to remove the helper-function completely. > > > (Being used 2 times.) > > Yup. > I didn't do that because I liked the comment that this is for the _Nonnull > implicit ARC casts – if I inline the function I have to duplicate the comment. Well, if you really like that, sure. I believe it is so common to avoid implicit casts we do not need to express it why. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77022/new/ https://reviews.llvm.org/D77022 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
