ZarkoCA marked 4 inline comments as done. ZarkoCA added inline comments.
================ Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019 + return SetCGInfo( + new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft")); return SetCGInfo( ---------------- jasonliu wrote: > ZarkoCA wrote: > > jasonliu wrote: > > > Does AIX have soft Float? If not, do we want to always pass in 'false'? > > Thanks, missed changing this. I set it to hard. > I don't think `CodeGenOpts.FloatABI == "hard"` is what we want though. > Currently it means if CodeGenOpts.FloatABI is really "hard", then it will > pass in `true` for `SoftFloatABI` to indicate we are soft float ABI. You're right. I wanted to keep the symmetry but that's not the correct thing to do. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.llvm.org/D76360 _______________________________________________ cfe-commits mailing list email@example.com https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits