chill marked 3 inline comments as done.
chill added inline comments.
================
Comment at: clang/include/clang/AST/Type.h:3588
+ NoCallerSavedRegsMask | NoCfCheckMask | CmseNSCallMask),
RegParmOffset = 8
}; // Assumed to be the last field
----------------
snidertm wrote:
> Shouldn't RegParmOffset be updated to 9, I believe it is used to shift the
> regParm value so that it encoded in the bits above CmseNSCallMask
Hmm, I think 8 is OK, but we should mask it ...
================
Comment at: clang/include/clang/AST/Type.h:3622
bool getNoCfCheck() const { return Bits & NoCfCheckMask; }
bool getHasRegParm() const { return (Bits >> RegParmOffset) != 0; }
----------------
... here.
bool getHasRegParm() const { return ((Bits & RegParmMask) >> RegParmOffset)
!= 0;
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71129/new/
https://reviews.llvm.org/D71129
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
