[PATCH] D77246: Instead of scream, why not roll?

[Diab Neiroukh via Phabricator via cfe-commits]

lazerl0rd created this revision.
lazerl0rd added reviewers: nathanchance, clang.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Everyone naturally converts hex to text when they see a long
value, so provide clearer information on their bad coding habits
with a nice link.

If you're still a bit lazy, why not use 
https://www.browserling.com/tools/hex-to-text?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77246

Files:
  clang/lib/CodeGen/PatternInit.cpp


Index: clang/lib/CodeGen/PatternInit.cpp
===================================================================
--- clang/lib/CodeGen/PatternInit.cpp
+++ clang/lib/CodeGen/PatternInit.cpp
@@ -24,7 +24,7 @@
   const uint64_t IntValue =
       CGM.getContext().getTargetInfo().getMaxPointerWidth() < 64
           ? 0xFFFFFFFFFFFFFFFFull
-          : 0xAAAAAAAAAAAAAAAAull;
+          : 0x68747470733a2f2f74696e7975726c2e636f6d2f32666370726536;
   // Floating-point values are initialized as NaNs because they propagate. 
Using
   // a repeated byte pattern means that it will be easier to initialize
   // all-floating-point aggregates and arrays with memset. Further, aggregates



Index: clang/lib/CodeGen/PatternInit.cpp
===================================================================
--- clang/lib/CodeGen/PatternInit.cpp
+++ clang/lib/CodeGen/PatternInit.cpp
@@ -24,7 +24,7 @@
   const uint64_t IntValue =
       CGM.getContext().getTargetInfo().getMaxPointerWidth() < 64
           ? 0xFFFFFFFFFFFFFFFFull
-          : 0xAAAAAAAAAAAAAAAAull;
+          : 0x68747470733a2f2f74696e7975726c2e636f6d2f32666370726536;
   // Floating-point values are initialized as NaNs because they propagate. Using
   // a repeated byte pattern means that it will be easier to initialize
   // all-floating-point aggregates and arrays with memset. Further, aggregates

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits