DiggerLin added inline comments.
================ Comment at: llvm/lib/MC/MCXCOFFStreamer.cpp:48 + Symbol->setStorageClass(XCOFF::C_WEAKEXT); + Symbol->setExternal(true); + break; ---------------- jasonliu wrote: > Maybe we should just move `Symbol->setExternal(true);` outside of the switch, > as it is set for every attribute that we are going to emit. I think there is Symbol->setExternal(false ) in other switch cases later . ================ Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:351 + if (nameShouldBeInStringTable(ContainingCsect->getSectionName())) + Strings.add(ContainingCsect->getSectionName()); + } ---------------- jasonliu wrote: > We should `continue` here if the rest of the logic does not matter. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
