jdoerfert updated this revision to Diff 255830. jdoerfert added a comment. Add comma
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77683/new/ https://reviews.llvm.org/D77683 Files: llvm/docs/CodeReview.rst Index: llvm/docs/CodeReview.rst =================================================================== --- llvm/docs/CodeReview.rst +++ llvm/docs/CodeReview.rst @@ -30,7 +30,9 @@ (or patches where the developer owns the component) that meet likely-community-consensus requirements (as apply to all patch approvals) can be committed prior to an explicit review. In situations where there is any -uncertainty, a patch should be reviewed prior to being committed. +uncertainty, a patch should be reviewed prior to being committed. If pre-commit +code reviewes in a particular area have been requested, code should clear a +significantly higher bar, e.g., fixes, to be commited without review. Please note that the developer responsible for a patch is also responsible for making all necessary review-related changes, including
Index: llvm/docs/CodeReview.rst =================================================================== --- llvm/docs/CodeReview.rst +++ llvm/docs/CodeReview.rst @@ -30,7 +30,9 @@ (or patches where the developer owns the component) that meet likely-community-consensus requirements (as apply to all patch approvals) can be committed prior to an explicit review. In situations where there is any -uncertainty, a patch should be reviewed prior to being committed. +uncertainty, a patch should be reviewed prior to being committed. If pre-commit +code reviewes in a particular area have been requested, code should clear a +significantly higher bar, e.g., fixes, to be commited without review. Please note that the developer responsible for a patch is also responsible for making all necessary review-related changes, including
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
