b-sumner added a comment. In D77910#1981429 <https://reviews.llvm.org/D77910#1981429>, @arsenm wrote:
> In D77910#1976171 <https://reviews.llvm.org/D77910#1976171>, @b-sumner wrote: > > > I don't think we can guarantee this is or will be supported on all devices. > > The language runtime makes this decision. > > > We don't need to worry about theoretical devices. We should know the > properties of the driver from -amdhsa, -amdpal, -mesa3d It takes more than support in the ISA for some features. The OpenCL driver may not want to support a given optional feature, e.g. images. I'm not opposed to defaults, but if the driver chooses to not support images, it needs to be able to prevent `__IMAGE_SUPPORT__` from being defined. Conformance will fail if the runtime and compiler are not consistent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77910/new/ https://reviews.llvm.org/D77910 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
