sdesmalen added inline comments.
================ Comment at: llvm/lib/Target/AArch64/AArch64.td:607 + FeatureSVE + ]>; + ---------------- Not sure how accurate the link you referenced is, but it doesn't mention SVE or Crypto extensions. Is that an omission in the blog post? ================ Comment at: llvm/unittests/Support/Host.cpp:271 +BogoMIPS : 62.50 +Features : fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm dcpop +CPU implementer : 0x4e ---------------- nit: it probably doesn't matter much for the function `getHostCPUNameForARM`, but the feature list seems incomplete. ================ Comment at: llvm/unittests/Support/TargetParserTest.cpp:980 + AArch64::AEK_CRC | AArch64::AEK_CRYPTO | AArch64::AEK_FP | + AArch64::AEK_SIMD | AArch64::AEK_FP16 | AArch64::AEK_RAS | + AArch64::AEK_LSE | AArch64::AEK_SVE | AArch64::AEK_RDM, ---------------- nit: odd indentation here, have you used clang-format? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits