Typz added a comment.

In D50078#1998398 <https://reviews.llvm.org/D50078#1998398>, @dyung wrote:

> Hi, this change that you submitted in commit 
> 5daa25fd7a184524759b6ad065a8bd7e95aa149a 
> <https://reviews.llvm.org/rG5daa25fd7a184524759b6ad065a8bd7e95aa149a> seems 
> to be causing the test "Clang-Unit :: 
> Format/./FormatTests.exe/FormatTest.ConfigurableUseOfTab" to randomly fail 
> about 50% of the time on Windows.
>
> Take the most recent 5 runs of the 
> llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast buildbot. Builds #31973 
> <http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/31973>,
>  31975 
> <http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/31975>
>  and 31976 
> <http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/31976>
>  all failed because of that test failing.
>
> On my local Windows computer, if I build your commit and run the FormatTest 
> unit test multiple times (the same binary without changing anything or 
> rebuilding), that above test fails roughly 50% of the time.
>
> Can you take a look to figure out why your change might be causing this 
> instability?


Hi,
That is very strange indeed, nothing is supposed to be random here...
I will try to have a look, but I don't have a windows computer to test, and 
never seen this issue on linux/macos :-/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50078/new/

https://reviews.llvm.org/D50078



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to