Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.
LGTM.
As with every change to the build system, please look out broken configurations
after committing. You will have noticed already that there is a lot of variety
in how others build LLVM, and its not possible for one person to test them all.
================
Comment at: llvm/cmake/modules/AddLLVM.cmake:952-953
+
+ ## Part 2: Extension header that captures each extension dependency, to
be
+ # by llvm-config.
+ set(ExtensionDeps
"${LLVM_BINARY_DIR}/tools/llvm-config/ExtensionDependencies.inc")
----------------
[typo] double 'be'
================
Comment at: llvm/cmake/modules/AddLLVM.cmake:959
+ foreach(llvm_extension ${LLVM_STATIC_EXTENSIONS})
+ get_property(llvm_plugin_deps TARGET ${llvm_extension} PROPERTY
LINK_LIBRARIES)
+ list(LENGTH llvm_plugin_deps llvm_plugin_deps_length)
----------------
In contrast to the LLVMBuild.txt system, this actually uses cmake to get the
dependency. Very cool! I am not sure whether `LINK_LIBRARIES` also includes
transitive dependencies.
I think the community would love to see the LLVMBuild.txt gone completely.
Interested in working on that?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78192/new/
https://reviews.llvm.org/D78192
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
