sameerds accepted this revision. sameerds added a comment. This revision is now accepted and ready to land.
Thanks @saiislam ... this looks much better! Two nitpicks, that must be fixed. But it is okay if you directly submit after fixing them. 1. The change description should use "const char *" in the signature and not "String". 2. Can you please add a test that passes an integer constant as the scope? I am assuming that the signature check will complain that it is not a string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75917/new/ https://reviews.llvm.org/D75917 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
