MyDeveloperDay added a comment.
Could you add to the review description a link to the systemd style guide that
says it should be like this?
================
Comment at: clang/docs/ClangFormatStyleOptions.rst:2311
+ * ``SBPO_ControlStatementsExceptForEachMacros`` (in configuration:
+ ``ControlStatementsExceptForEachMacros``)
----------------
Normally this would be generated from the Format.h after running the dump style
script in tools, did you?
================
Comment at: clang/include/clang/Format/Format.h:1958
+ SBPO_ControlStatementsExceptForEachMacros,
/// Put a space before opening parentheses only if the parentheses are not
/// empty i.e. '()'
----------------
can you move this down below this comment which applies to
`SBPO_ControlStatements` and add your own comment explaining why you might NOT
want them in front of the ForeachEach Macros which I have to say I'm confused
why you wouldn't but then its not for me to understand you style requirements.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78869/new/
https://reviews.llvm.org/D78869
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
