NoQ added a comment.

If your change causes a crash, please debug it. That's a completely normal 
thing that programmers do every day. Unfortunately, I can't afford to 
spoon-feed you the solution step-by-step.



================
Comment at: clang/lib/StaticAnalyzer/Core/SymbolManager.cpp:601-603
+    if (LCtx->getAnalysis<RelaxedLiveVariables>()->isLive(Loc,
+                                                          PR->getOriginExpr()))
+      return true;
----------------
> I implemented the basic `isLive()` and `getBinding()` functions which reduced 
> the number of failing tests by `0`.

This line in particular is very incorrect. In fact, most of the time the result 
will be `false`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77229/new/

https://reviews.llvm.org/D77229



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to