sdesmalen added a comment. Now that most of the functionality has been added to SveEmitter.cpp and CGBuiltin.cpp, the patches are becoming simpler and simpler. This patch is such an example, which is basically "builtin definitions + tests".
This is probably a good point to ask for some feedback how to best get these patches into Clang without spamming your inboxes too much :) I can choose to do this in individual patches for similar 'groups' of operations (like this patch does it). Alternatively I could collate them all into a single patch and put that up for review. Or I can just commit such simple changes directly if you think there is little value in reviewing these (note that any patches that require code-changes or that add some macro in the arm_sve.h header file would still go through normal review process, the question is purely about structurally simple patches like this). Do you have any preference/suggestions how to best approach this? I'm also happy to add other reviewers, but I'm not sure who best to add. If you have suggestions, please let me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78960/new/ https://reviews.llvm.org/D78960 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
