MaskRay closed this revision. MaskRay added a comment. @browneee Hi, it seems that you did not attach `Differential Revision: ` to the commit dda3c19a3618dce9492687f8e880e7a73486ee98 <https://reviews.llvm.org/rGdda3c19a3618dce9492687f8e880e7a73486ee98> so the differential was not closed automatically.
In previous llvm-dev discussions, people agreed that `Reviewed-by:` and `Differential Revision: ` are useful and should be retained. I usually do this when committing: `arcfilter; git fetch origin master && git rebase origin/master; last-minute-testing && git push origin HEAD:master` where `arcfilter` is a shell function which drops unneeded Phabricator tags arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend -F - } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits