sammccall accepted this revision.
sammccall added a comment.
Still LG
================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:1047
Server, FooHPath, RenamePos, NewName, {/*CrossFile=*/true}));
+ EXPECT_THAT(Tracer.takeMetric("rename_files"), SizeIs(1));
EXPECT_THAT(
----------------
I think this one should be elementsAre(2) though rather than just asserting
that there's some measurement?
================
Comment at: clang-tools-extra/clangd/unittests/support/TestTracer.cpp:33
+ return {};
+ return std::move(ValuesIt->getValue());
+}
----------------
nit: vector's moved-from state is unspecified :-(
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78429/new/
https://reviews.llvm.org/D78429
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
