xazax.hun added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:385
+
+ RangeSet VisitAndOperator(RangeSet LHS, RangeSet RHS, QualType T) {
+ // TODO: generalize for the ranged RHS.
----------------
I always get surprised when I read code like the one above seeing that only RHS
is tested for being a concerte value. Later on, I vaguely start to remember
that we only produce `SymIntExpr`s (is that correct?). I wonder if we should
add an assert so this code blows up when someone is trying to add
`IntSymExpr`s, so she will know what code needs modification.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79232/new/
https://reviews.llvm.org/D79232
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
